Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: error index reporter improvements #3994

Merged
merged 5 commits into from
Oct 24, 2023
Merged

chore: error index reporter improvements #3994

merged 5 commits into from
Oct 24, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Oct 19, 2023 •
edited
Loading

Description

  • Respect transaction while reporting in error index reporter.
  • Support declaring transaction listeners in reporters.
  • Support declaratively stopping the reporting service.
  • Support different jobsdbs for different syncers in error index reporter.

Linear Ticket

Resolves PIPE-430

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (e74cd7d) 71.62% compared to head (19f98db) 71.33%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3994      +/-   ##
==========================================
- Coverage   71.62%   71.33%   -0.30%     
==========================================
  Files         368      369       +1     
  Lines       54153    54226      +73     
==========================================
- Hits        38785    38680     -105     
- Misses      13064    13241     +177     
- Partials     2304     2305       +1
Files Coverage Δ
app/apphandlers/embeddedAppHandler.go 74.91% <100.00%> (+0.08%) ⬆️
enterprise/reporting/mediator.go 95.00% <100.00%> (+1.12%) ⬆️
jobsdb/backup.go 65.87% <ø> (ø)
jobsdb/jobsdb.go 73.03% <100.00%> (-0.96%) ⬇️
jobsdb/migration.go 69.85% <ø> (-0.64%) ⬇️
router/factory.go 100.00% <ø> (ø)
router/handle_observability.go 49.64% <100.00%> (-23.75%) ⬇️
utils/tx/tx.go 100.00% <100.00%> (ø)
warehouse/app.go 89.50% <100.00%> (+0.03%) ⬆️
...use/integrations/middleware/sqlquerywrapper/sql.go 91.92% <100.00%> (-0.08%) ⬇️
... and 11 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atzoum atzoum mentioned this pull request Oct 19, 2023
Merged
1 task
@atzoum atzoum force-pushed the chore.errIdxReporter branch 2 times, most recently from 52d5ca0 to d0b3a79 Compare October 19, 2023 12:29
lvrach
lvrach approved these changes Oct 24, 2023
View reviewed changes
enterprise/reporting/error_index_reporting.go Outdated Show resolved Hide resolved
@atzoum atzoum merged commit 55f0737 into master Oct 24, 2023
35 checks passed
@atzoum atzoum deleted the chore.errIdxReporter branch October 24, 2023 14:25
This was referenced Oct 30, 2023
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvrach lvrach lvrach approved these changes

@achettyiitr achettyiitr achettyiitr approved these changes

@fracasula fracasula Awaiting requested review from fracasula

@cisse21 cisse21 Awaiting requested review from cisse21

@sanpj2292 sanpj2292 Awaiting requested review from sanpj2292

@gane5hvarma gane5hvarma Awaiting requested review from gane5hvarma

@Sidddddarth Sidddddarth Awaiting requested review from Sidddddarth

@BonapartePC BonapartePC Awaiting requested review from BonapartePC

Assignees
No one assigned
Labels
warehouse-team with tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atzoum @lvrach @achettyiitr